# project: Make \`textDocument/signatureHelp\` implementation lsp compliant \(\#40707\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/67b9d480b444ef3e44b01e722fd595dbdf2c02a9)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 67b9d480b444ef3e44b01e722fd595dbdf2c02a9

Requested commit: 67b9d480b444ef3e44b01e722fd595dbdf2c02a9

Commit: 67b9d480b444ef3e44b01e722fd595dbdf2c02a9

Tree: 0491daf68e22038d67abf3eac1d05b4cd8df4e1b

Author: Lukas Wirth

Committer: GitHub

## Message

```
project: Make `textDocument/signatureHelp` implementation lsp compliant (#40707)

The parameter label offsets are utf16 offsets, not utf8. Additionally we
now validate the language server output.

Closes https://github.com/zed-industries/zed/issues/40578

Companion bug on rust-analyzer side
https://github.com/rust-lang/rust-analyzer/pull/20876

Release Notes:

- Fixed `textDocument/signatureHelp` implementation not being LSP
compliant
```

## Parents

- [30f3152e65d04ed477d1589d70e33ce29f15dd1b](https://git.cafe/gitcafe/zed/commit/30f3152e65d04ed477d1589d70e33ce29f15dd1b?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/67b9d480b444ef3e44b01e722fd595dbdf2c02a9?format=markdown)