# terminal_view: Ensure terminal toggle shortcut appears in tooltip \(\#52357\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/64d4e01061f42e6d0a3e9f0c4f638e3d69b5abc3)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 64d4e01061f42e6d0a3e9f0c4f638e3d69b5abc3

Requested commit: 64d4e01061f42e6d0a3e9f0c4f638e3d69b5abc3

Commit: 64d4e01061f42e6d0a3e9f0c4f638e3d69b5abc3

Tree: 57dc6f74c7bb9f26a49fefff9a1c88a636711c3e

Author: Michael Smolkin

Committer: GitHub

## Message

```
terminal_view: Ensure terminal toggle shortcut appears in tooltip (#52357)

Follow-up to the discussion in #51670.

@ConradIrwin, thanks for the review!

You're right about the other editors. VS Code and JetBrains use
dedicated shortcuts for bottom panel tabs, which exactly mirrors how
`ctrl-`` already behaves in Zed, so we don't need a new keybinding.

The reason I originally proposed `cmd-shift-j` was just to match the UI
pattern of the Debugger, which clearly shows `cmd-shift-d` on hover.
Because of a minor UI discoverability bug, the Terminal button's tooltip
was completely blank, which made it look like it just lacked a shortcut
entirely.

It turns out the Terminal button's internal `toggle_action()` method was
just telling the UI to look up `ToggleFocus` instead of
`terminal_panel::Toggle` (which is what `ctrl-`` is actually bound to).

I've updated this branch with a simple one-word fix that just points the
`toggle_action` to the correct keymap. The existing `ctrl-`` shortcut
now shows up perfectly in the hover tooltip. Good catch on the existing
shortcuts, keeps this much cleaner.

Co-authored-by: Michael Smolkin <msmolkin@users.noreply.github.com>
```

## Parents

- [d3ab0d9daf0c54de4c08c1daa53768d1a5da965b](https://git.cafe/gitcafe/zed/commit/d3ab0d9daf0c54de4c08c1daa53768d1a5da965b?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/64d4e01061f42e6d0a3e9f0c4f638e3d69b5abc3?format=markdown)