# git_ui: Always display "Create Pull Request" button on push toast \(\#53913\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/62b4fd26cfe71ae157532f40b7b1c8e58492553d)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 62b4fd26cfe71ae157532f40b7b1c8e58492553d

Requested commit: 62b4fd26cfe71ae157532f40b7b1c8e58492553d

Commit: 62b4fd26cfe71ae157532f40b7b1c8e58492553d

Tree: f31f9c2f4437695db2ee73ca8324d939a080043f

Author: Dino

Committer: GitHub

## Message

```
git_ui: Always display "Create Pull Request" button on push toast (#53913)

Update the toast shown after running `git: push` so as to always include
a button to create a pull request for the current branch.

We used to only do this on the initial push, as that is when the output
of running `git push` would include an URL that could be used to create
the Pull Request. However, since we now have a `git: create pull
request`, we can always build this URL, meaning we no longer need to
rely on the command's output in order to display the "Create Pull
Request" button.

Something worth noting is that the
`git_ui::remote_output::format_output` function used to also match on
Bitbucket's terminal output, so these changes include the implementation
of `GitHostingProvider::build_create_pull_request_url` for the
`Bitbucket` provider.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Improved the toast shown after `git: push` to always display the
"Create Pull Request" button
```

## Parents

- [18c98b021168dee458a4721d44b3618f5f2d1adb](https://git.cafe/gitcafe/zed/commit/18c98b021168dee458a4721d44b3618f5f2d1adb?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/62b4fd26cfe71ae157532f40b7b1c8e58492553d?format=markdown)