# editor: Ensure all menus and popups are dismissed \(\#43169\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/5ef6402d645b40993e58704a2ba735015cc7f668)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 5ef6402d645b40993e58704a2ba735015cc7f668

Requested commit: 5ef6402d645b40993e58704a2ba735015cc7f668

Commit: 5ef6402d645b40993e58704a2ba735015cc7f668

Tree: cb0141aa600a5f86c65a7111c7a935ce784899bf

Author: Dino

Committer: GitHub

## Message

```
editor: Ensure all menus and popups are dismissed (#43169)

While investigating a bug report that, in Helix mode, pressing the
`escape` key would only hide the signature help popup and not the
completions menu, when `auto_signature_help` was enabled, it was noted
that the `editor::Editor.dismiss_menus_and_popups` method was not
dismissing all possible menus and popups and was, instead, stopping as
soon as a single menu or popup was dismissed.

From the name of the method it appears that we actually want to dismiss
all so this commit updates it as such, ensuring that the bug reported is
also fixed.

Closes #42499 

Release Notes:

- Fixed issue with popups and menus not being dismissed while using
`auto_signature_help` in Helix Mode
```

## Parents

- [ba93a5d62f87f40fa87fb69b45f8c1dda65ad845](https://git.cafe/gitcafe/zed/commit/ba93a5d62f87f40fa87fb69b45f8c1dda65ad845?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/5ef6402d645b40993e58704a2ba735015cc7f668?format=markdown)