# macos: Reset exception ports for shell-spawned processes \(\#44193\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/5bfc0baa4cd0dd49646d6fdcbe9d4a2fb34cefa7)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 5bfc0baa4cd0dd49646d6fdcbe9d4a2fb34cefa7

Requested commit: 5bfc0baa4cd0dd49646d6fdcbe9d4a2fb34cefa7

Commit: 5bfc0baa4cd0dd49646d6fdcbe9d4a2fb34cefa7

Tree: cf930d520c2da1b333f6c3f9f6cbdf633379c3aa

Author: Rémi Kalbe

Committer: GitHub

## Message

```
macos: Reset exception ports for shell-spawned processes (#44193)

## Summary

Follow-up to #40716. This applies the same `reset_exception_ports()` fix
to `set_pre_exec_to_start_new_session()`, which is used by shell
environment capture, terminal spawning, and DAP transport.

### Root Cause

After more debugging, I finally figured out what was causing the issue
on my machine. Here's what was happening:

1. Zed spawns a login shell (zsh) to capture environment variables
2. A pipe is created: reader in Zed, writer mapped to fd 0 in zsh
3. zsh sources `.zshrc` → loads oh-my-zsh → runs poetry plugin
4. Poetry plugin runs `poetry completions zsh &|` in background
5. Poetry inherits fd 0 (the pipe's write end) from zsh
6. zsh finishes `zed --printenv` and exits
7. Poetry still holds fd 0 open
8. Zed's `reader.read_to_end()` blocks waiting for all writers to close
9. Poetry hangs (likely due to inherited crash handler exception ports
interfering with its normal operation)
10. Pipe stays open → Zed stuck → no more processes spawn (including
LSPs)

I confirmed this by killing the hanging `poetry` process, which
immediately unblocked Zed and allowed LSPs to start. However, this
workaround was needed every time I started Zed.

While poetry was the culprit in my case, this can affect any shell
configuration that spawns background processes during initialization
(oh-my-zsh plugins, direnv, asdf, nvm, etc.).

Fixes #36754

## Test plan

- [x] Build with `ZED_GENERATE_MINIDUMPS=true` to force crash handler
initialization
- [x] Verify crash handler logs appear ("spawning crash handler
process", "crash handler registered")
- [x] Confirm LSPs start correctly with shell plugins that spawn
background processes

Release Notes:

- Fixed an issue on macOS where LSPs could fail to start when shell
plugins spawn background processes during environment capture.
```

## Parents

- [d7b99a5b12a18e4bad360a1745b882b3823773ed](https://git.cafe/gitcafe/zed/commit/d7b99a5b12a18e4bad360a1745b882b3823773ed?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/5bfc0baa4cd0dd49646d6fdcbe9d4a2fb34cefa7?format=markdown)