# collab ui: Dismiss project shared notifications when leaving room \(\#10160\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/5b4ff74dcac678356e6625944bb539c157522c2f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 5b4ff74dcac678356e6625944bb539c157522c2f

Requested commit: 5b4ff74dcac678356e6625944bb539c157522c2f

Commit: 5b4ff74dcac678356e6625944bb539c157522c2f

Tree: 82806e09012b802bacae73b22fa0626396c862c1

Author: Bennet Bo Fenner

Committer: GitHub

## Message

```
collab ui: Dismiss project shared notifications when leaving room (#10160)

When leaving a call/room in which a project was shared, the shared
project notification was not getting dismissed when the person that
shared the project left the room.
Although there was a `cx.emit(Event::Left)` call inside room, the event
was never received in the `project_shared_notification` module, because
the room is dropped before the event can be dispatched. Moving the
`cx.emit(Event::Left)` to the active call fixed the problem. Also
renamed `Event::Left` to `Event::RoomLeft` because the room join
equivalent is also called `Event::RoomJoined`.


Release Notes:

- Fixed project shared notification staying open, when the user that
shared the project left the room
```

## Parents

- [8e9543aefe223223e21d43b200ec73333fa36776](https://git.cafe/gitcafe/zed/commit/8e9543aefe223223e21d43b200ec73333fa36776?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/5b4ff74dcac678356e6625944bb539c157522c2f?format=markdown)