# gpui: Round \`scroll_max\` to two decimal places \(\#34832\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/5b3e37181240d8ed1ef8e04aa0593c7ca5f46a6c)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 5b3e37181240d8ed1ef8e04aa0593c7ca5f46a6c

Requested commit: 5b3e37181240d8ed1ef8e04aa0593c7ca5f46a6c

Commit: 5b3e37181240d8ed1ef8e04aa0593c7ca5f46a6c

Tree: e2ddd5dfe696772e898cb7f431b696cc02b9280a

Author: Finn Evers

Committer: GitHub

## Message

```
gpui: Round `scroll_max` to two decimal places (#34832)

Follow up to #31836 

After enabling rounding in the Taffy layout engine, we frequently run
into cases where the bounds produced by Taffy and ours slightly differ
after 5 or more decimal places. This leads to cases where containers
become scrollable for less than 0.0000x Pixels. In case this happens for
e.g. hover popovers, we render a scrollbar due to the container being
technically scrollable, even though the scroll amount here will in
practice never be visible.

This change fixes this by rounding the `scroll_max` by which we clamp
the current scroll position to two decimal places. We don't benefit from
the additional floating point precision here at all and it stops such
containers from becoming scrollable altogether. Furthermore, we now
store the `scroll_max` instead of the `padded_content_size` as the
former gives a much better idea on whether the corresponding container
is scrollable or not.

| `main` | After these changes |
| -- | -- |
| <img width="610" height="316" alt="main"
src="https://github.com/user-attachments/assets/ffcc0322-6d6e-4f79-a916-bd3c57fe4211"
/> | <img width="610" height="316" alt="scroll_max_rounded"
src="https://github.com/user-attachments/assets/5fe530f5-2e21-4aaa-81f4-e5c53ab73e4f"
/> |

Release Notes:

- Fixed an issue where scrollbars would appear in containers where no
scrolling was possible.
```

## Parents

- [8eca7f32e2041c648c3c9b0ac1e8b686fec4e5df](https://git.cafe/gitcafe/zed/commit/8eca7f32e2041c648c3c9b0ac1e8b686fec4e5df?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/5b3e37181240d8ed1ef8e04aa0593c7ca5f46a6c?format=markdown)