# settings_ui: Get editor settings working \(\#37330\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/54cec5b484c3e71b5fe47331e1e21ad0cf801425)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 54cec5b484c3e71b5fe47331e1e21ad0cf801425

Requested commit: 54cec5b484c3e71b5fe47331e1e21ad0cf801425

Commit: 54cec5b484c3e71b5fe47331e1e21ad0cf801425

Tree: d1f3d5ceafff826db7acea55b5545625a478eea0

Author: Ben Kunkle

Committer: GitHub

## Message

```
settings_ui: Get editor settings working (#37330)

Closes #ISSUE

This PR includes the necessary work to get `EditorSettings` showing up
in the settings UI. Including making the `path` field on
`SettingsUiItem`'s optional so that top level items such as
`EditorSettings` which have `Settings::KEY = None` (i.e. are treated
like `serde(flatten)`) have their paths computed correctly for JSON
reading/updating.

It includes the first examples of a pattern I expect to continue with
the `SettingsUi` work with respect to settings reorganization, that
being adding missing defaults, and adding explicit values (or aliases)
to settings which previously relied on `null` being a value for optional
fields.

Release Notes:

- N/A *or* Added/Fixed/Improved ...
```

## Parents

- [60d17cccd35b919d6226ae86559c4505d7c1e833](https://git.cafe/gitcafe/zed/commit/60d17cccd35b919d6226ae86559c4505d7c1e833?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/54cec5b484c3e71b5fe47331e1e21ad0cf801425?format=markdown)