# client: Parse auth callback query parameters before showing sign-in success page \(\#36440\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/50819a9d208917344d913800e818fe37e71974a8)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 50819a9d208917344d913800e818fe37e71974a8

Requested commit: 50819a9d208917344d913800e818fe37e71974a8

Commit: 50819a9d208917344d913800e818fe37e71974a8

Tree: 2c7de9844333f7e881dc7bf342a6dac88ed4847b

Author: Marshall Bowers

Committer: GitHub

## Message

```
client: Parse auth callback query parameters before showing sign-in success page (#36440)

This PR fixes an issue where we would redirect the user's browser to the
sign-in success page even if the OAuth callback was malformed.

We now parse the OAuth callback parameters from the query string and
only redirect to the sign-in success page when they are valid.

Release Notes:

- Updated the sign-in flow to not show the sign-in success page
prematurely.
```

## Parents

- [3a3df5c0118e942893dd3f12aa0c2f734ffae0af](https://git.cafe/gitcafe/zed/commit/3a3df5c0118e942893dd3f12aa0c2f734ffae0af?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/50819a9d208917344d913800e818fe37e71974a8?format=markdown)