# Filter language server completions even when \`is_incomplete: true\` \(\#32491\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/4f5433a1804b843f8712fec7badfd1a6e909ecef)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 4f5433a1804b843f8712fec7badfd1a6e909ecef

Requested commit: 4f5433a1804b843f8712fec7badfd1a6e909ecef

Commit: 4f5433a1804b843f8712fec7badfd1a6e909ecef

Tree: efd52b966d2254d29881964b0faeb2fd04bb2f16

Author: Michael Sloan

Committer: GitHub

## Message

```
Filter language server completions even when `is_incomplete: true` (#32491)

In #31872 I changed the behavior of completions to not filter instead of
requerying completions when `is_incomplete: false`. Unfortunately this
also stopped filtering completions when `is_incomplete: true` - we still
want to filter the incomplete completions so that the menu updates
quickly even when completions are slow. This does mean that the
completions menu will display partial results, hopefully only briefly
while waiting for fresh completions.

Thanks to @mikayla-maki for noticing the regression. Thankfully just in
time to fix it before this makes it into a stable release. Leaving off
release notes since I will cherry-pick this to the current preview
version, 190.x, and there probably won't be a preview release before the
next stable.

Release Notes:

- N/A
```

## Parents

- [295db79c47cf90f38597d6b6436a3c010b8226f9](https://git.cafe/gitcafe/zed/commit/295db79c47cf90f38597d6b6436a3c010b8226f9?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/4f5433a1804b843f8712fec7badfd1a6e909ecef?format=markdown)