# dev_container: Parse env vars and docker labels with \`=\` in values correctly \(\#53134\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/4b1e0a30b8ecf6b45da880e51b29a2d933c418a7)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 4b1e0a30b8ecf6b45da880e51b29a2d933c418a7

Requested commit: 4b1e0a30b8ecf6b45da880e51b29a2d933c418a7

Commit: 4b1e0a30b8ecf6b45da880e51b29a2d933c418a7

Tree: 33a53d620ebeb8a1ff49913cf6a7a922f32f8e90

Author: Peter Siegel

Committer: GitHub

## Message

```
dev_container: Parse env vars and docker labels with `=` in values correctly (#53134)

Fixes a parsing issue where docker env var key/value pairs can contain
an "=" character in the value. This is pretty common and present in all
[nvidia/cuda](https://hub.docker.com/r/nvidia/cuda) docker images. Also
adds some tests for env var parsing.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fixed a parsing failure where docker env var key/value pairs can
contain an "=" character in the value.
```

## Parents

- [1d0967cdda39f0e2dc599626b575063d77a0bf45](https://git.cafe/gitcafe/zed/commit/1d0967cdda39f0e2dc599626b575063d77a0bf45?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/4b1e0a30b8ecf6b45da880e51b29a2d933c418a7?format=markdown)