# git_ui: Fix double slash in commit URLs \(\#44996\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/4573a59777a905204c50e8f746bf9319febce9b1)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 4573a59777a905204c50e8f746bf9319febce9b1

Requested commit: 4573a59777a905204c50e8f746bf9319febce9b1

Commit: 4573a59777a905204c50e8f746bf9319febce9b1

Tree: 731434ab61df0effb59502e69ed156117517ee6d

Author: Xiaobo Liu

Committer: GitHub

## Message

```
git_ui: Fix double slash in commit URLs (#44996)

Release Notes:

- Fixed double slash in commit URLs

The github_url variable was generating URLs with an extra slash like
"https://github.com//user/repo/commit/xxxx" due to manual string
formatting
of the base_url() result.

Fixed by replacing manual URL construction with the proper
build_commit_permalink() method that uses Url::join() for correct
path handling, consistent with how other Git hosting providers
construct URLs.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
```

## Parents

- [7ba6f39e8284cb7b3522f137b0d724ad59740ddd](https://git.cafe/gitcafe/zed/commit/7ba6f39e8284cb7b3522f137b0d724ad59740ddd?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/4573a59777a905204c50e8f746bf9319febce9b1?format=markdown)