# Set override_redirect for PopUps \(\#42224\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/42d5f7e73e8597b26f4457399d4c5afa8fed24b0)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 42d5f7e73e8597b26f4457399d4c5afa8fed24b0

Requested commit: 42d5f7e73e8597b26f4457399d4c5afa8fed24b0

Commit: 42d5f7e73e8597b26f4457399d4c5afa8fed24b0

Tree: 69d72d01e798aca187b29799c1330eba6a0a2a29

Author: Lieunoir

Committer: GitHub

## Message

```
Set override_redirect for PopUps (#42224)

Currently on x11, gpui PopUp windows only rely on the "notification"
type in order to indicate that they should spawn as floating window.
Several window managers (leftwm in my case, but it also seems to be the
case for dwm and ratpoison) do not this property into account thus not
spawning them as float. On the other hand, using Floating instead of
PopUp do make those windows spawn as floating, as these window manager
do take into account the (older) "dialog" type.

The [freedekstop
documentation](https://specifications.freedesktop.org/wm/1.5/ar01s05.html#id-1.6.7)
does seem to suggest that these windows should also have the override
redirect property :
> This property is typically used on override-redirect windows. 

Note that this also disables pretty much all interactions with the
window manager (such as moving the window, resizing etc...)

Release Notes:

- Fix popup windows not spawning floating sometime on x11
```

## Parents

- [5395197619f612aef59bd80a1108de294cc2aa77](https://git.cafe/gitcafe/zed/commit/5395197619f612aef59bd80a1108de294cc2aa77?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/42d5f7e73e8597b26f4457399d4c5afa8fed24b0?format=markdown)