# settings_ui: Inform about keybind conflicts in modal \(\#34205\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/41085f8f55b7f81bbd68c24adf3784fe0ea50614)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 41085f8f55b7f81bbd68c24adf3784fe0ea50614

Requested commit: 41085f8f55b7f81bbd68c24adf3784fe0ea50614

Commit: 41085f8f55b7f81bbd68c24adf3784fe0ea50614

Tree: df81a063701ad1bb0700ad452a50c23ace666ee2

Author: Finn Evers

Committer: GitHub

## Message

```
settings_ui: Inform about keybind conflicts in modal (#34205)

This PR updates the keybinding editor modal so that conflicts are
already shown in the modal itself. Notably, this does not add validation
on every keystroke, the update still has to be confirmed. However, if
only a warning is present, on the second confirm the keybind will
actually be updated.

The change also includes a slight update to the displayment of errors,
since we now differentiate between errors and warnings.

| Error | Warning | 
| --- | --- |
| <img width="543" height="332" alt="warning_keybind"
src="https://github.com/user-attachments/assets/867319be-eeb9-40d7-bf32-fbd44aacf0b5"
/> | <img width="543" height="310" alt="error_keybind"
src="https://github.com/user-attachments/assets/858a6c7c-8c9a-4a90-95af-a5103125676f"
/> |


Release Notes:

- N/A
```

## Parents

- [8e1d341d09de32edfb7a05893f520ebd950c65a9](https://git.cafe/gitcafe/zed/commit/8e1d341d09de32edfb7a05893f520ebd950c65a9?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/41085f8f55b7f81bbd68c24adf3784fe0ea50614?format=markdown)