# themes: Improve Gruvbox terminal colors \(\#38536\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/38f4e21fe8bb72ceac5f601947919fd4d7d5f61e)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 38f4e21fe8bb72ceac5f601947919fd4d7d5f61e

Requested commit: 38f4e21fe8bb72ceac5f601947919fd4d7d5f61e

Commit: 38f4e21fe8bb72ceac5f601947919fd4d7d5f61e

Tree: f798901c98d6eec4432cc36509dd5c046b147572

Author: Dmitry Nefedov

Committer: GitHub

## Message

````
themes: Improve Gruvbox terminal colors (#38536)

This PR makes zed terminal gruvbox theme consistent with other terminals
themes.
Current ansi colors is broken, by not only not using colors from
original palette, but also by inverting of bright/normal colors...

Currently I took colors from Ghostty (Iterm2 themes), making sure that
they are consistent with palette.
For dim colors I darken them by decreasing "Value" from HSV
representation of colors by 30%.

I am open to discussion and willing to implement those changes for light
theme after receiving feedback.

Examples below:

| Before | After |
| - | - |
| <img width="489" height="472" alt="image"
src="https://github.com/user-attachments/assets/599dd162-6666-4705-adb7-1b62a7800f70"
/> | <img width="490" height="470" alt="image"
src="https://github.com/user-attachments/assets/fee02cc5-6ca8-4daa-88f1-7f37f27f2ce4"
/> |

Script to reproduce:
```bash
#!/bin/bash

echo "Normal ANSI Colors:"
for i in {30..37}; do
    printf "\e[${i}m  Text  \e[0m"
done
echo ""

echo "Bright ANSI Colors (Foreground):"
for i in {90..97}; do
    printf "\e[${i}m  Text  \e[0m"
done
echo ""

echo "Bright ANSI Colors (Background):"
for i in {100..107}; do
    printf "\e[${i}m  Text  \e[0m"
done
echo ""

echo "Foreground and Background Combinations:"
for fg in {30..37}; do
    for bg in {40..47}; do
        printf "\e[${fg};${bg}m  FB  \e[0m"
    done
    echo ""
done

echo "Bright Foreground and Background Combinations:"
for fg in {90..97}; do
    for bg in {100..107}; do
        printf "\e[${fg};${bg}m  FB  \e[0m"
    done
    echo ""
done
```


Release Notes:

- Fixed ANSI colors definitions in the Gruvbox theme (thanks @dangooddd)

---------

Co-authored-by: Oleksiy Syvokon <oleksiy@zed.dev>
````

## Parents

- [6067436e9b52ba68b811e163ab21513be8869496](https://git.cafe/gitcafe/zed/commit/6067436e9b52ba68b811e163ab21513be8869496?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/38f4e21fe8bb72ceac5f601947919fd4d7d5f61e?format=markdown)