# editor: Cancel blame popover task when opening modal \(\#52525\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/34dae654bc27f7b533b9cd79bd15963e0f73f44e)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 34dae654bc27f7b533b9cd79bd15963e0f73f44e

Requested commit: 34dae654bc27f7b533b9cd79bd15963e0f73f44e

Commit: 34dae654bc27f7b533b9cd79bd15963e0f73f44e

Tree: 0b5623f78d2e827bb8246f7fc1c1a2aafdac038b

Author: Tim Vermeulen

Committer: GitHub

## Message

```
editor: Cancel blame popover task when opening modal (#52525)

Update all direct calls to `Editor::inline_blame_popover::take` to now
be calls to `Editor::hide_blame_popover` as this ensures that the
popover is also not shown in case its task still hasn't finished.

This fixes a bug where the inline git blame popover could be shown even
after the user had opened a modal. 

Release Notes:

- Fixed the inline Git blame popover sometimes appearing after opening a
modal.

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
```

## Parents

- [4fbac78ff4c210bdcd17c953cdf5945875a1856d](https://git.cafe/gitcafe/zed/commit/4fbac78ff4c210bdcd17c953cdf5945875a1856d?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/34dae654bc27f7b533b9cd79bd15963e0f73f44e?format=markdown)