# client: Make \`Client::sign_in_with_optional_connect\` a no-op when already connected to Collab \(\#36449\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/33fbe53d48291c6c622e8d3b4bbf4d0210d41025)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 33fbe53d48291c6c622e8d3b4bbf4d0210d41025

Requested commit: 33fbe53d48291c6c622e8d3b4bbf4d0210d41025

Commit: 33fbe53d48291c6c622e8d3b4bbf4d0210d41025

Tree: ee06e92f29d6b582416f24130573b7b54a9721ea

Author: Marshall Bowers

Committer: GitHub

## Message

```
client: Make `Client::sign_in_with_optional_connect` a no-op when already connected to Collab (#36449)

This PR makes it so `Client::sign_in_with_optional_connect` does nothing
when the user is already connected to Collab.

This fixes the issue where clicking on a channel link would temporarily
disconnect you from Collab.

Release Notes:

- N/A
```

## Parents

- [567ceffd429d8711a0ef6674bd01f22dfc0e98ff](https://git.cafe/gitcafe/zed/commit/567ceffd429d8711a0ef6674bd01f22dfc0e98ff?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/33fbe53d48291c6c622e8d3b4bbf4d0210d41025?format=markdown)