# Only show preview line numbers if enabled by user \(\#59957\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/2bb81ba8f3a568a1793a9a8ba844c0c6c2e1dfb3)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 2bb81ba8f3a568a1793a9a8ba844c0c6c2e1dfb3

Requested commit: 2bb81ba8f3a568a1793a9a8ba844c0c6c2e1dfb3

Commit: 2bb81ba8f3a568a1793a9a8ba844c0c6c2e1dfb3

Tree: 5d1bdbae828b19b254e7c66fee8f28e1057b7c97

Author: Aleksei Gusev

Committer: GitHub

## Message

```
Only show preview line numbers if enabled by user (#59957)

# Objective

- Currently, the file preview pane in pickers forces line numbers and
the editor gutter to always be visible, ignoring user-configured
preferences. This PR ensures the preview component respects the user's
global editor layout settings.

## Solution

- Modified `EditorPreview::new` within `crates/picker/src/preview.rs`.
- Imported `EditorSettings` from the `editor` crate.
- Replaced the hardcoded `true` values for `set_show_gutter` and
`set_show_line_numbers` with the user's active global configuration
retrieved via `EditorSettings::get_global(cx).gutter.line_numbers`.

## Testing

- Did you test these changes? If so, how?
- Yes, manually verified that toggling line numbers off or using
relative line numbers in `settings.json` is accurately reflected inside
the picker's file preview pane.
- Are there any parts that need more testing?
- No, using the global context lookup seamlessly integrates with Zed's
existing configuration lifecycle.
- How can other people (reviewers) test your changes? Is there anything
specific they need to know?
- Open your `settings.json` and change your line number preferences
(e.g., set `"line_numbers": false`).
- Bring up a picker that renders a file preview (like the project search
or file finder).
- Confirm that the preview pane's gutter and line number layout
perfectly matches your active configuration.
- If relevant, what platforms did you test these changes on, and are
there any important ones you can't test?
  - Tested on Linux.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

## Showcase

<details>
  <summary>Click to view showcase</summary>

### Line numbers ON

<img width="1940" height="2072" alt="preview-line-numbers-on"
src="https://github.com/user-attachments/assets/db824b5e-bc29-459d-bc0c-86762d44f707"
/>

### Line numbers OFF

<img width="1940" height="2072" alt="preview-line-numbers-off"
src="https://github.com/user-attachments/assets/48a6357e-d4b5-462b-920f-d1c20d3d27af"
/>

</details>

---

Release Notes:

- Preview line numbers now respect user configuration settings
```

## Parents

- [d7b9b28deb7b7fa3a4e594745cb851e4d0180f5a](https://git.cafe/gitcafe/zed/commit/d7b9b28deb7b7fa3a4e594745cb851e4d0180f5a?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/2bb81ba8f3a568a1793a9a8ba844c0c6c2e1dfb3?format=markdown)