# gpui: Small tab group performance improvements \(\#41885\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/2a713c546b80cfc1dcf678953336f3758d1b152b)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 2a713c546b80cfc1dcf678953336f3758d1b152b

Requested commit: 2a713c546b80cfc1dcf678953336f3758d1b152b

Commit: 2a713c546b80cfc1dcf678953336f3758d1b152b

Tree: 735cd20a47fe74aabf229c5821046f6f2b4e6f06

Author: tidely

Committer: GitHub

## Message

```
gpui: Small tab group performance improvements (#41885)

Closes #ISSUE

Removes a few eager container clones and iterations.

Added a todo to `get_prev_tab_group_window` and
`get_next_tab_group_window`. They seem to use `HashMap::keys()` for
choosing the previous tab group, however `.keys()` returns an arbitrary
order, so I'm not sure if previous actually means anything here. Conrad
seems to have worked on this part previously, maybe he has some
insights. That can possibly be a follow-up PR, but I'd be willing to
work on it here as well since the other changes are so simple.

Release Notes:

- N/A
```

## Parents

- [f937c1931fe382ad08f0d96b529f8a0428166d7c](https://git.cafe/gitcafe/zed/commit/f937c1931fe382ad08f0d96b529f8a0428166d7c?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/2a713c546b80cfc1dcf678953336f3758d1b152b?format=markdown)