# settings: accept trailing commas \(\#2606\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/2a3c660d1fbdd17fd90cec4bdc0bf12b101e643b)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 2a3c660d1fbdd17fd90cec4bdc0bf12b101e643b

Requested commit: 2a3c660d1fbdd17fd90cec4bdc0bf12b101e643b

Commit: 2a3c660d1fbdd17fd90cec4bdc0bf12b101e643b

Tree: 9b895fba8971434d362fa9054efdca48fa34afed

Author: Piotr Osiewicz

Committer: GitHub

## Message

```
settings: accept trailing commas (#2606)

Z-2357

I've found a crate that handles both comments and trailing commas in
JSON. It is a fork of `serde_json`, but it is maintained & up-to-date.
Sadly RawValue seems to not play nicely with it; I've ran into
deserialisation issues around use of RawValue. For this PR I've migrated
to `Value` API.

Obviously this is just a point of discussion, not something I'd merge
straight away. There may be better solutions to this particular problem.

I've also noticed that `serde_json_lenient` does not handle trailing
commas after bindings array. I'm not sure how big of an issue that is.

Release Notes:
- Improved handling of trailing commas in settings files.
[#1322](https://github.com/zed-industries/community/issues/1322)
```

## Parents

- [70ccbbafc109f664facf1ccdcfe743f6b829df87](https://git.cafe/gitcafe/zed/commit/70ccbbafc109f664facf1ccdcfe743f6b829df87?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/2a3c660d1fbdd17fd90cec4bdc0bf12b101e643b?format=markdown)