# vim: Change into visual mode on select all matches \(\#24897\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/294dea10e89e4975f37ba0c4053f2228b77aa31f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 294dea10e89e4975f37ba0c4053f2228b77aa31f

Requested commit: 294dea10e89e4975f37ba0c4053f2228b77aa31f

Commit: 294dea10e89e4975f37ba0c4053f2228b77aa31f

Tree: c297c0b8bc1c4eec281d8d6145c900631b30f025

Author: Dino

Committer: GitHub

## Message

```
vim: Change into visual mode on select all matches (#24897)

This Pull Request fixes an issue where selecting all matches on a search
would not update vim to visual mode.

In the video below the following scenarios are tested:

1. Clicking "Select All Matches" in the buffer search bar correctly
changes vim to visual mode
2. Pressing Enter jumps the cursor to the first match and does not
change vim's mode
3. Selecting all matches with the `⌥⏎` changes vim to visual mode


https://github.com/user-attachments/assets/f7535638-987e-4f33-9364-292f99b60167

Thanks @ConradIrwin for both the quick pairing session and the solution!
🙇

Closes #14681 

Release Notes:

- vim: Use visual mode for "select all matches" in search (to be
consistent with `ga`)
```

## Parents

- [fc85ca0101e6987b3a69009b96b1aa9d9d68fe0a](https://git.cafe/gitcafe/zed/commit/fc85ca0101e6987b3a69009b96b1aa9d9d68fe0a?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/294dea10e89e4975f37ba0c4053f2228b77aa31f?format=markdown)