# Remove \`into SelectionEffects\` from \.change_selections · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/28380d714d6dd32f5d7e242d690483714fa3f969)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 28380d714d6dd32f5d7e242d690483714fa3f969

Requested commit: 28380d714d6dd32f5d7e242d690483714fa3f969

Commit: 28380d714d6dd32f5d7e242d690483714fa3f969

Tree: a237f0fd276f978813e255d66ead8ce98e6f3805

Author: Conrad Irwin

Committer: Conrad Irwin

## Message

```
Remove `into SelectionEffects` from .change_selections

In #32656 I generalized the argument to change selections to allow
controling both the scroll and the nav history (and the completion
trigger).

To avoid conflicting with ongoing debugger cherry-picks I left the
argument as an `impl Into<>`, but I think it's clearer to make callers
specify what they want here.

I converted a lot of `None` arguments to `SelectionEffects::no_scroll()`
to be exactly compatible; but I think many people used none as an "i
don't care" value in which case Default::default() might be more
appropraite

```

## Parents

- [f338c46bf79f773ec7a41729270227da8c2660b5](https://git.cafe/gitcafe/zed/commit/f338c46bf79f773ec7a41729270227da8c2660b5?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/28380d714d6dd32f5d7e242d690483714fa3f969?format=markdown)