# Add supports_disabling_thinking to Cloud model listings \(\#58980\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/20a3f7705f18a9913571d4fcdee687b76abdb213)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 20a3f7705f18a9913571d4fcdee687b76abdb213

Requested commit: 20a3f7705f18a9913571d4fcdee687b76abdb213

Commit: 20a3f7705f18a9913571d4fcdee687b76abdb213

Tree: a23c28fc0513c92722f0460d12ce8ec9af643daf

Author: Eric Holk

Committer: GitHub

## Message

```
Add supports_disabling_thinking to Cloud model listings (#58980)

Claude Fable 5 always thinks and cannot honor a request with thinking
disabled, but the cloud models listing gives clients no way to tell it
apart from models where thinking is optional (e.g. Claude Opus 4.6):
both report `supports_thinking: true` plus the same adaptive effort
levels. As a result, the agent panel shows a thinking toggle for Fable
even though turning it off isn't actually supported.

zed-industries/cloud#2789 adds a `supports_disabling_thinking` field to
the models listing. This PR mirrors it through
`cloud_llm_client::LanguageModel` (serde-defaulted to `false`, so a
server without the field is treated as "don't claim thinking can be
turned off") and exposes it as
`LanguageModel::supports_disabling_thinking()`, forwarded from the
listing by `CloudLanguageModel`. The agent panel now hides the thinking
toggle for models that report `false`, showing only the effort selector.

The trait default is `true`: every non-cloud provider in the tree treats
thinking as toggleable today, and only the cloud listing knows about
always-thinking models.

Draft until zed-industries/cloud#2789 lands and deploys.

Release Notes:

- Fixed the agent panel offering a thinking toggle for models that
cannot run with thinking disabled.
```

## Parents

- [9053e7dd1cd9da8a3a170cbfe8680bd0f137f5ad](https://git.cafe/gitcafe/zed/commit/9053e7dd1cd9da8a3a170cbfe8680bd0f137f5ad?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/20a3f7705f18a9913571d4fcdee687b76abdb213?format=markdown)
