# Fix font feature tag validation \(\#13542\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/18b457306431c76e7a41cdff419f7be918dd359b)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 18b457306431c76e7a41cdff419f7be918dd359b

Requested commit: 18b457306431c76e7a41cdff419f7be918dd359b

Commit: 18b457306431c76e7a41cdff419f7be918dd359b

Tree: 5bb95577285e226f75b3361b726423f5306409ee

Author: 张小白

Committer: GitHub

## Message

```
Fix font feature tag validation (#13542)

The previous implementation that I implemented had two issues:
1. It did not throw an error when the user input some invalid values
such as "panic".
2. The feature tag for OpenType fonts should be a combination of letters
and digits. We only checked if the input was an ASCII character, which
could lead to undefined behavior.

Closes #13517 

Release Notes:

- N/A
```

## Parents

- [d044dc8485bb97290b7adb6c701e12db838aef38](https://git.cafe/gitcafe/zed/commit/d044dc8485bb97290b7adb6c701e12db838aef38?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/18b457306431c76e7a41cdff419f7be918dd359b?format=markdown)