# gpui: move Option \-\> Result conversion out of closure in App::update_window_id \(\#37624\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/16c4fd4fc563eeedc645a50931129908bc3bfb07)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 16c4fd4fc563eeedc645a50931129908bc3bfb07

Requested commit: 16c4fd4fc563eeedc645a50931129908bc3bfb07

Commit: 16c4fd4fc563eeedc645a50931129908bc3bfb07

Tree: efa2c12937b3be8ea3cebcea9e9a5b4a6ffa063c

Author: Jakub Konka

Committer: GitHub

## Message

```
gpui: move Option -> Result conversion out of closure in App::update_window_id (#37624)

Doesn't fix anything, but it seems that we do not need to assert and
convert into an error until after the closure run to completion,
especially since this is the only error we throw.

Release Notes:

- N/A
```

## Parents

- [ec58adca131ce2232ccd186947213e6255e6987d](https://git.cafe/gitcafe/zed/commit/ec58adca131ce2232ccd186947213e6255e6987d?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/16c4fd4fc563eeedc645a50931129908bc3bfb07?format=markdown)