# Use \`anyhow\` more idiomatically \(\#31052\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/16366cf9f26b2f41a95c36e613acc6ed0c78c94c)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 16366cf9f26b2f41a95c36e613acc6ed0c78c94c

Requested commit: 16366cf9f26b2f41a95c36e613acc6ed0c78c94c

Commit: 16366cf9f26b2f41a95c36e613acc6ed0c78c94c

Tree: 638e530cb4439ec3f2f727c33653ee5cd960c8eb

Author: Kirill Bulatov

Committer: GitHub

## Message

```
Use `anyhow` more idiomatically (#31052)

https://github.com/zed-industries/zed/issues/30972 brought up another
case where our context is not enough to track the actual source of the
issue: we get a general top-level error without inner error.

The reason for this was `.ok_or_else(|| anyhow!("failed to read HEAD
SHA"))?; ` on the top level.

The PR finally reworks the way we use anyhow to reduce such issues (or
at least make it simpler to bubble them up later in a fix).
On top of that, uses a few more anyhow methods for better readability.

* `.ok_or_else(|| anyhow!("..."))`, `map_err` and other similar error
conversion/option reporting cases are replaced with `context` and
`with_context` calls
* in addition to that, various `anyhow!("failed to do ...")` are
stripped with `.context("Doing ...")` messages instead to remove the
parasitic `failed to` text
* `anyhow::ensure!` is used instead of `if ... { return Err(...); }`
calls
* `anyhow::bail!` is used instead of `return Err(anyhow!(...));`

Release Notes:

- N/A
```

## Parents

- [1e51a7ac44238d23d333a72ee619ee9dd52718aa](https://git.cafe/gitcafe/zed/commit/1e51a7ac44238d23d333a72ee619ee9dd52718aa?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/16366cf9f26b2f41a95c36e613acc6ed0c78c94c?format=markdown)