# Remove Default impl for ConnectionId \(\#7452\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/1264e36429fcc715d1778341c775388dcab7e8a0)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 1264e36429fcc715d1778341c775388dcab7e8a0

Requested commit: 1264e36429fcc715d1778341c775388dcab7e8a0

Commit: 1264e36429fcc715d1778341c775388dcab7e8a0

Tree: f737ec265739d19e701949364dd6dfc13b3610aa

Author: Max Brunsfeld

Committer: GitHub

## Message

````
Remove Default impl for ConnectionId (#7452)

We noticed the following message in my logs when trying to debug some
lag when collaborating:

```
2024-02-06T09:42:09-08:00 [ERROR] error handling message. client_id:3, sender_id:Some(PeerId { owner_id: 327, id: 1123430 }), type:GetCompletions, error:no such connection: 0/0
```

That `0/0` looks like a bogus connection id, constructed via a derived
`Default`. We didn't ever find a code path that would *use* a default
`ConnectionId` and lead to this error, but it did seem like an
improvement to not have a `Default` for that type.

Release Notes:

- N/A

Co-authored-by: Marshall <marshall@zed.dev>
````

## Parents

- [4e519e3af7e7cfa5db68dceb5938025dbca3b61b](https://git.cafe/gitcafe/zed/commit/4e519e3af7e7cfa5db68dceb5938025dbca3b61b?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/1264e36429fcc715d1778341c775388dcab7e8a0?format=markdown)