# Fix diagnostic popover not overflowing when necessary \(\#14322\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/11178eacc797a558b95151d13ef9cf07aefa64f2)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 11178eacc797a558b95151d13ef9cf07aefa64f2

Requested commit: 11178eacc797a558b95151d13ef9cf07aefa64f2

Commit: 11178eacc797a558b95151d13ef9cf07aefa64f2

Tree: 217ac20a01dcdd9129cdf772211e8a7c03f61a84

Author: Stanislav Alekseev

Committer: GitHub

## Message

```
Fix diagnostic popover not overflowing when necessary (#14322)

It was broken after #13996 moved rendering text one level deeper,
causing `max_h` and `overflow_y_scroll` to apply to different widgets
Release Notes:

- Fixed large diagnostic popovers not overflowing when nessesary

Before:
<img width="814" alt="Screenshot 2024-07-12 at 15 25 46"
src="https://github.com/user-attachments/assets/4f615600-2857-4470-8b77-864e3a9e38d5">

After:
<img width="813" alt="Screenshot 2024-07-12 at 15 26 10"
src="https://github.com/user-attachments/assets/83c1f344-b3b1-4929-8197-4b24a0e9c65e">
```

## Parents

- [59bc0277506e5d0a3a9cba06933633da2e34692c](https://git.cafe/gitcafe/zed/commit/59bc0277506e5d0a3a9cba06933633da2e34692c?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/11178eacc797a558b95151d13ef9cf07aefa64f2?format=markdown)