# Hide BasedPyright banner in toolbar when dismissed \(\#38135\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/0fef17baa23130557813bd688ab0d3064bf4681e)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 0fef17baa23130557813bd688ab0d3064bf4681e

Requested commit: 0fef17baa23130557813bd688ab0d3064bf4681e

Commit: 0fef17baa23130557813bd688ab0d3064bf4681e

Tree: 93f4f60809a8a3f866ff792e0346dd243eee79c0

Author: Vladimir Varankin

Committer: GitHub

## Message

```
Hide BasedPyright banner in toolbar when dismissed (#38135)

This PR fixes the `BasedPyrightBanner`, making sure the banner is
completely hidden in the toolbar, when it was dismissed, or it's not
installed.

Without the fix, the banner still occupies some space in the toolbar,
making the UI looks inconsistent when editing a Python file. The bug is
**especially prominent** when the toolbar is hidden in the user's
settings (see below).

_Banner is shown_
<img width="1470" height="254" alt="Screenshot 2025-09-14 at 11 36 37"
src="https://github.com/user-attachments/assets/1415b075-0660-41ed-8069-c2318ac3a7cf"
/>

_Banner dismissed_
<img width="1470" height="207" alt="Screenshot 2025-09-14 at 11 36 44"
src="https://github.com/user-attachments/assets/828a3fba-5c50-4aba-832c-3e0cc6ed464b"
/>

_Banner dismissed (and the toolbar is hidden)_
<img width="1470" height="177" alt="Screenshot 2025-09-14 at 12 07 25"
src="https://github.com/user-attachments/assets/41aa5861-87df-491f-ac7e-09fc1558dd84"
/>

Closes n/a

Release Notes:

- Fixed the basedpyright onboarding banner
```

## Parents

- [526196917b40287462013c70eb1b61c1332effa8](https://git.cafe/gitcafe/zed/commit/526196917b40287462013c70eb1b61c1332effa8?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/0fef17baa23130557813bd688ab0d3064bf4681e?format=markdown)