# workspace: Only suppress auto-save on focus transfer for the Vim/Helix command palette \(\#51949\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/0b557a5f5c366b65be0bb9fa60f1197ee37a4ee0)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 0b557a5f5c366b65be0bb9fa60f1197ee37a4ee0

Requested commit: 0b557a5f5c366b65be0bb9fa60f1197ee37a4ee0

Commit: 0b557a5f5c366b65be0bb9fa60f1197ee37a4ee0

Tree: bbbb41c9dc785c196968cd4aa72cc19fb4b420dc

Author: Marshall Bowers

Committer: GitHub

## Message

```
workspace: Only suppress auto-save on focus transfer for the Vim/Helix command palette (#51949)

This PR adjusts the logic that was added in #45166 to just apply to the
specific case of interacting with the command palette in Vim and Helix
modes (hereafter referred to collectively as "Vim mode").

In that PR, we would suppress the auto-save on focus change for _any_
modal in the workspace, regardless of whether we were actually in Vim
mode or not. This would cause issues where moving between files some
other way—such as the tab switcher or the file finder—would cause the
buffers to never be saved.

We now only suppress the auto-save on focus loss behavior when in Vim
mode and the active modal is the command palette. In all other cases, we
save the file.

Closes https://github.com/zed-industries/zed/issues/47968.

Supersedes https://github.com/zed-industries/zed/pull/51801 and
https://github.com/zed-industries/zed/pull/51802.

Note: the way we are identifying the active modal as the command palette
isn't the best, but @bennetbo and I didn't have any other cleaner
solutions. It's a bit tricky, as the logic lives in the `workspace`,
which isn't able to know about the `CommandPalette` due to
`command_palette` depending on `workspace`. There may be some other way
we could achieve this with more indirection, but it's unclear whether it
would be worth it at this time.

Release Notes:

- Changed `{ "autosave": "on_focus_change" }` to now always save on
focus loss, except for when activating the command palette when in
Vim/Helix mode.

Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
```

## Parents

- [68d96077f319dea338adfef9f789a4952273dde8](https://git.cafe/gitcafe/zed/commit/68d96077f319dea338adfef9f789a4952273dde8?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/0b557a5f5c366b65be0bb9fa60f1197ee37a4ee0?format=markdown)