# language_models: Fix GitHub Copilot thread summary by removing unnecessary noop tool logic \(\#37152\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/0a32aa8db1c4bbd4ae8977b0923ece0f32537074)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 0a32aa8db1c4bbd4ae8977b0923ece0f32537074

Requested commit: 0a32aa8db1c4bbd4ae8977b0923ece0f32537074

Commit: 0a32aa8db1c4bbd4ae8977b0923ece0f32537074

Tree: 7d579a76456671e3ea77ef0b68989c6b23731276

Author: Umesh Yadav

Committer: GitHub

## Message

````
language_models: Fix GitHub Copilot thread summary by removing unnecessary noop tool logic (#37152)

Closes #37025 

This PR fixes GitHub Copilot thread summary failures by removing the
unnecessary `noop` tool insertion logic. The code was originally added
as a workaround in https://github.com/zed-industries/zed/pull/30007 for
supposed GitHub Copilot API issues when tools were used previously in a
conversation but no tools are provided in the current request. However,
testing revealed that this scenario works fine without the workaround,
and the `noop` tool insertion was actually causing "Invalid schema for
function 'noop'" errors that prevented thread summarization from
working. Removing this logic eliminates the errors and allows thread
summarization to function correctly with GitHub Copilot models.

The best way to see if removing that part of code works is just
triggering thread summarisation.

Error Log:
```
2025-08-27T13:47:50-04:00 ERROR [workspace::notifications] "Failed to connect to API: 400 Bad Request {"error":{"message":"Invalid schema for function 'noop': In context=(), object schema missing properties.","code":"invalid_function_parameters"}}\n"
```

Release Notes:

- Fixed GitHub Copilot thread summary failures by removing unnecessary
noop tool insertion logic.
````

## Parents

- [b473f4a1304bc1a4b2e911cc6063167ede3a281c](https://git.cafe/gitcafe/zed/commit/b473f4a1304bc1a4b2e911cc6063167ede3a281c?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/0a32aa8db1c4bbd4ae8977b0923ece0f32537074?format=markdown)
