# Remove editor::Cancel binding from vim · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/0733e8d50f0ffa3339cb03c14b661ca2f4334d9f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 0733e8d50f0ffa3339cb03c14b661ca2f4334d9f

Requested commit: 0733e8d50f0ffa3339cb03c14b661ca2f4334d9f

Commit: 0733e8d50f0ffa3339cb03c14b661ca2f4334d9f

Tree: 54193954367bdcc35b2c3a6aca988d9fec1a3996

Author: Conrad Irwin

Committer: Conrad Irwin

## Message

```
Remove editor::Cancel binding from vim

When you hit <escape> in the command palette, it first editor::Cancel
because the command palette is also a focused editor; this binding was
catching before the `menu::Cancel` that you probably want.

From looking at the uses of editor::Cancel it seems like the only way to
trigger this is with <escape> in an editor. Rather than trying to hook
into the existing editor cancel and add vim-specific behaviour, we'll
instead take responsibility for binding directly to <escape> when
necessary.

Fixes: zed-industries/community#1347

```

## Parents

- [fe57e04016c120eb83441b8722febed1f6b4984f](https://git.cafe/gitcafe/zed/commit/fe57e04016c120eb83441b8722febed1f6b4984f?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/0733e8d50f0ffa3339cb03c14b661ca2f4334d9f?format=markdown)