# editor: Fix panics that could occur when content mask had negative bounds \(\#47327\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/01d72aa7d6de1117420c3cad14021f03c8a92a90)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 01d72aa7d6de1117420c3cad14021f03c8a92a90

Requested commit: 01d72aa7d6de1117420c3cad14021f03c8a92a90

Commit: 01d72aa7d6de1117420c3cad14021f03c8a92a90

Tree: b7839cb3d129e5dbe6cd57f68c547661606c44cf

Author: Anthony Eid

Committer: GitHub

## Message

```
editor: Fix panics that could occur when content mask had negative bounds (#47327)

Closes #47157

This panic happened because the editor was using `window.content_mask`
to get the visible bounds, which had a negative value for its height in
some cases.

This happened for three reasons:

1. `Bounds::from_corners` returns a negative size if callers pass in
corners where `bottom_right < top_left`. I originally wanted to add
error checking to this function but didn't, because it might be better
to move the error checking higher up. For now I'm going to push a fix
and figure out a better solution later

2. `Bounds::intersect` could return negative-sized bounds when the two
bounds didn't overlap, instead of returning a zero sized bounds.

3. `Style::paint` sometimes passed invalid corner values to
`Bounds::from_corners` (where the computed bottom-right was above/left
of the top-left).

Release Notes:

- editor: Fix a crash that could happen when editor visible line height
is zero

---------

Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
```

## Parents

- [c9997592e4378c8a09aee799307aaf62b79311a7](https://git.cafe/gitcafe/zed/commit/c9997592e4378c8a09aee799307aaf62b79311a7?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/01d72aa7d6de1117420c3cad14021f03c8a92a90?format=markdown)