library-wide check: every page has a skeleton, empty state and error state#608

opened1d agobyMMalek Gara-Hellal

no one has checked every list and page for a loading state and an empty state together. a code and screenshot pass found these gaps (the skeleton ones are also in the loading issue, this one is the checklist).

loading: no placeholder

  • home made for you (components/mix-row.tsx returns null while pending)
  • following: your artists and new releases (pages/following.tsx)
  • folders root and folder view (pages/folders.tsx)
  • settings sections that read the server (pages/settings.tsx)
  • listen and playlist folder show a text line instead of a layout (pages/listen.tsx, pages/playlist-folder.tsx)

empty or error: bare text with no next step

  • /artist/<unknown id> shows only "artist not found" (pages/detail.tsx): no link back, no search
  • search with no hits shows only nothing matches "x" (pages/search.tsx): no hint to check the spelling, try another filter, or add the song (add-track.tsx exists)
  • an unknown route (check routes.tsx) has the same problem
  • folders: "empty" and "empty folder" say nothing about why (pages/folders.tsx)
  • upload off says "uploads are off on this server · an admin sets UPLOAD_DIR" which is jargon for a non admin (pages/upload.tsx)

what good looks like: one rule in components/library.tsx / skeletons.tsx: every list or page has (1) a skeleton with the real geometry, delayed 150 ms, (2) an empty state with one sentence and one action, (3) an error state with retry (the made for you row already does this). add an e2e check that walks the main routes with the network slowed and with an empty mock library so a missing state fails the build.

first part shipped in #641 (following, folders, playlist folder, listen). still without a loading, empty or error state: settings sections that read the server, import and upload, an unknown artist page (no way back), search with no hits, an unknown route, the folders empty states, and the upload-off text that mentions UPLOAD_DIR. also open: an empty-library mock that walks every route.