refetch cover action for albums and artists#607

opened1d agobyMMalek Gara-Hellal

some album covers are wrong and there is no way to fix one from the player.

where: album and artist pages (apps/player/src/pages/detail.tsx), the item menu (apps/player/src/components/item-menu.tsx), cover route cover() in apps/api/src/api.ts (cached on disk and served immutable, keyed by the cover id), and the cover archive proxy releaseCover() in the same file.

who owns what: lyterion owns the art that ends up in the files and in navidrome. lodesong only shows what navidrome returns, so a wrong cover in the files stays wrong for every client. lodesong can still correct what this player shows and ask lyterion to fix the source.

what good looks like:

  • an item menu action "refetch cover" on an album (and a smaller one on an artist for the picture), admin or owner only
  • it searches Cover Art Archive first (by the album's musicbrainz id when tags have one, else by artist + album title through the existing musicbrainz client) and deezer second, and shows up to 6 candidates in a dialog with a size label (500, 1000 px) so the person picks one, with the current cover marked
  • picking one stores a per-account override on the server (disk file + a row mapping the navidrome cover id to it) and the cover() route serves the override before asking navidrome. because the url is immutable, the override needs a new version in the cover url (a short hash in the query) so browsers drop the old one
  • "use original" removes the override
  • if lyterion is configured (lyterionAdd is on), a second button "also fix the files" sends the choice to lyterion so the tag art is replaced and navidrome rescans; lyterion needs an endpoint for that (not there today) and should keep the old art until the rescan finishes
  • the action shows a loader while searching and a clear message when nothing is found

also worth a check on the lyterion side: why the wrong art got picked (matching on title only, compilations, deluxe vs standard), so the cause stops producing more of them.