Delete stale diagnostics and the cart placeholder#215

openedJul 18, 2026byAAviddaram

Parent

https://github.com/darjss/vit-store/issues/198

Accepted audit ID: D-01.

What to build

Delete only the confirmed unowned development surfaces:

  • storefront /audit
  • storefront /test
  • Admin sandbox route and its implementation
  • scaffold cart.hello procedure
  • references invalidated solely by those deletions

Explicitly retain /benchmark and all supporting benchmark components, API procedures, and Product benchmark implementation. The benchmark tooling is maintained and useful.

Acceptance criteria

  • /audit, /test, and the Admin sandbox are absent from generated routing and real browser navigation.
  • cart.hello and references made obsolete by its removal are absent.
  • /benchmark and all supporting benchmark behavior remain intact and render through real boundaries.
  • Retained health, catalogue, cart, and dashboard behavior remains unchanged.
  • Generated route files are regenerated through supported tooling, never hand-edited.
  • Applicable static/build checks and signed-out/signed-in browser proof pass without unrelated behavior changes.

Blocked by

None — Portless routing and authenticated Helium access are available.

Implementation stopped at the plan's route-generation STOP gate.

Sanitized evidence: the required admin build succeeds, but deleting _dash/sandbox.tsx and regenerating apps/admin/src/routeTree.gen.ts also changes unrelated existing route contracts (/orders/, /products/, and /purchases/ normalize without trailing slashes, and the dashboard root generated full path changes). Those changes are not references made invalid solely by the sandbox deletion, so accepting them would exceed D-01 scope; hand-editing generated output is expressly prohibited.

No external owner or active consumer was found in repository references, public issue/PR search, or file history for the named stale surfaces. No delivery commit or PR was created. Human decision is required on whether to accept the generator-wide route normalization or first land a separate generated-route baseline update.

Browser proof is blocked by the required local origins before application routing. With exact-head Admin listening on 3005 and storefront listening on 4321, all three operator-specified HTTPS origins return the same proxy-level 404: https://admin.vitstore.dev/, https://api.vitstore.dev/health-check, and https://vitstore.dev/. The response is not emitted by Vit Store (it includes the local HTTPS proxy marker), and port 3006 is unavailable because local API startup is separately blocked by expired Cloudflare development authorization.

Per instruction, I did not restart Caddy, replace the origins, use localhost browser proof, or alter proxy configuration. The Helium session was closed, local processes were stopped, experimental source changes were restored, and no commit/PR was created. Issue remains ready-for-human until the three required origins route to ports 3005/3006/4321 and API development authorization is valid.

Implementation is now committed and pushed as draft PR #247 while browser proof remains paused: https://github.com/darjss/vit-store/pull/247

Non-browser gates completed: Admin build/regeneration passed, storefront build passed, API package build passed, focused stale symbol/path searches are clean, and retained health/cache diagnostics remain. Per the latest operator instruction, no further browser attempt was made and Caddy/Portless were not changed. The PR remains draft and the issue remains ready-for-human pending a confirmed Vit Store route for signed-in proof.

Maintainer decision: keep the storefront /benchmark route and all Product-benchmark code/components it requires. Continue only with the other confirmed stale artifacts: /audit, /test, the Admin sandbox route, and the scaffold cart.hello path, plus references made invalid solely by those deletions. Generator-owned Admin route normalization is acceptable only after real route verification. The discarded PR #247 remains closed and unmerged.