# Close the gaps review found in viewer lineups · dara/icarus

[View on GitCafe](https://git.cafe/dara/icarus/commit/e15d0a04c1fa5e85f8559ab9b84ffd8d16087f34)

Repository: [dara/icarus](https://git.cafe/dara/icarus)

Visibility: public

Requested revision: e15d0a04c1fa5e85f8559ab9b84ffd8d16087f34

Requested commit: e15d0a04c1fa5e85f8559ab9b84ffd8d16087f34

Commit: e15d0a04c1fa5e85f8559ab9b84ffd8d16087f34

Tree: 895744d991b02497113adc02a39c2976ce18f10b

Author: Dara Adedeji

Committer: Dara Adedeji

## Message

```
Close the gaps review found in viewer lineups

- The canvas drop target sat above the moved pointer block, so a drag
  started as an editor could still land after the role dropped to
  viewer. The drop now checks edit access when it lands.
- Pressing a lineup end holds it, and a held lineup counted as editing
  in presence. Viewers now never broadcast lineup editing: the check
  lives in myLineupEditingProvider, so it covers holds, placements and
  open dialogs, and follows role changes while a panel is open. The
  panel's one-off check is gone.
- The tests now drive the real InteractiveMap, check the hovered delete
  target, and try to drag an ordinary placed agent; presence is checked
  in the provider test, where pages and lineup groups exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

```

## Parents

- [e97cbbdecc33f7cc23354a5a6a0df8f0b38f7cec](https://git.cafe/dara/icarus/commit/e97cbbdecc33f7cc23354a5a6a0df8f0b38f7cec?format=markdown)

[Source at this commit](https://git.cafe/dara/icarus/tree/e15d0a04c1fa5e85f8559ab9b84ffd8d16087f34?format=markdown)