# Cut tests that can't fail and make weak ones catch regressions · dara/icarus

[View on GitCafe](https://git.cafe/dara/icarus/commit/98bf450eed2a02cff4c72b396decf95e4506204c)

Repository: [dara/icarus](https://git.cafe/dara/icarus)

Visibility: public

Requested revision: 98bf450eed2a02cff4c72b396decf95e4506204c

Requested commit: 98bf450eed2a02cff4c72b396decf95e4506204c

Commit: 98bf450eed2a02cff4c72b396decf95e4506204c

Tree: e299e233f1bab1707115c6f6408ab7819ba00efe

Author: Dara Adedeji

Committer: Dara Adedeji

## Message

```
Cut tests that can't fail and make weak ones catch regressions

An audit of all 630 tests found 25 that guard nothing: they assert a
constant equals itself, print a benchmark, or repeat a stronger test on
the same code path. They are removed.

Eighteen more guarded real behavior but could not fail. The largest:
the .ica round-trip tests imported and exported through copies of the
production code kept inside the test file, so a broken importer still
passed. They now go through loadFromFilePath and zipStrategy against a
throwaway Hive library, every fixture round-trips, and corrupt files
must fail without saving. Skipping migration in the real importer now
fails the fixture test; before, it passed.

The rest: assertions too loose to fail, expected values computed by the
code under test, setup that never reached the branch named in the
title, and a Windows-only provider path that could not tell its two
entry points apart.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

```

## Parents

- [d8f2a2d33a714708d7ff30d7b0d4c08cec15a5e6](https://git.cafe/dara/icarus/commit/d8f2a2d33a714708d7ff30d7b0d4c08cec15a5e6?format=markdown)

[Source at this commit](https://git.cafe/dara/icarus/tree/98bf450eed2a02cff4c72b396decf95e4506204c?format=markdown)