# Stop Convex contract previews from piling up and steady the upgrade test cleanup \(\#205\) · dara/icarus

[View on GitCafe](https://git.cafe/dara/icarus/commit/8ce645e605dff1e2116669cf51dc7b5de1b39a5f)

Repository: [dara/icarus](https://git.cafe/dara/icarus)

Visibility: public

Requested revision: 8ce645e605dff1e2116669cf51dc7b5de1b39a5f

Requested commit: 8ce645e605dff1e2116669cf51dc7b5de1b39a5f

Commit: 8ce645e605dff1e2116669cf51dc7b5de1b39a5f

Tree: e2197fc50ba5cc5ffb696db718a4e0467409c286

Author: Dara Adedeji

Committer: GitHub

## Message

```
Stop Convex contract previews from piling up and steady the upgrade test cleanup (#205)

The convex-contract job left one preview deployment behind per PR, and
after about 25 merged PRs the team hit its deployment quota of 40, so
every PR failed with DeploymentQuotaReached. The job now records the
preview's URL when Convex claims it (via --cmd, which runs before the
push), sets it to expire in an hour, and deletes it in a final always()
step through the Management API using the same preview deploy key.

The Windows upgrade and rollback test removed the app support folder
straight after killing Icarus, so a helper still holding 000003.log made
the delete fail, and because it threw inside finally it hid the real
result. Cleanup now waits for Icarus and any process using the support
folder to exit, retries the delete, and only fails the run when the test
itself passed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
```

## Parents

- [66dc33dc843a7987bb69c3ef85980aa6fd3b4fe9](https://git.cafe/dara/icarus/commit/66dc33dc843a7987bb69c3ef85980aa6fd3b4fe9?format=markdown)

[Source at this commit](https://git.cafe/dara/icarus/tree/8ce645e605dff1e2116669cf51dc7b5de1b39a5f?format=markdown)