# Never join on a failed link lookup; keep links usable without the people list · dara/icarus

[View on GitCafe](https://git.cafe/dara/icarus/commit/0a028946201e617aa911c9fea7471509cb1302f8)

Repository: [dara/icarus](https://git.cafe/dara/icarus)

Visibility: public

Requested revision: 0a028946201e617aa911c9fea7471509cb1302f8

Requested commit: 0a028946201e617aa911c9fea7471509cb1302f8

Commit: 0a028946201e617aa911c9fea7471509cb1302f8

Tree: 845cbce71407e6a40595b40a56467f70644ed1ae

Author: Dara Adedeji

Committer: Dara Adedeji

## Message

```
Never join on a failed link lookup; keep links usable without the people list

A signed-in person opening a link whose preview fails (offline, or a
server without shares:preview) is now told so and the code stays held,
instead of falling through to redeeming it. The dialog loads links and
people separately, so the links still work when the people can't be
read, and the role switches rebuild on every read so a change the server
refused shows the role it kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

```

## Parents

- [d7edf50c4c4dd4f94c921714a639fb6fa0941f7b](https://git.cafe/dara/icarus/commit/d7edf50c4c4dd4f94c921714a639fb6fa0941f7b?format=markdown)

[Source at this commit](https://git.cafe/dara/icarus/tree/0a028946201e617aa911c9fea7471509cb1302f8?format=markdown)